netdev - Re: [net-next 13/15] ixgbe: clean up ixgbe_atr_compute_perfect_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140320.142033.306107166278366828.davem@davemloft.net>
Date:	Thu, 20 Mar 2014 14:20:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	jeffrey.t.kirsher@...el.com, jacob.e.keller@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	asharma@...com
Subject: Re: [net-next 13/15] ixgbe: clean up
 ixgbe_atr_compute_perfect_hash_82599

From: David Laight <David.Laight@...LAB.COM>
Date: Thu, 20 Mar 2014 09:44:58 +0000

> From: Jeff Kirsher
>> From: Jacob Keller <jacob.e.keller@...el.com>
>> 
>> Rather than assign several parameters in a row, we should use a for
>> loop, which reduces code size.
> 
> And probably increases execution time.
> Especially for the first two blocks.

This is not a fast path, so code size is more important than execution
time here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html