netdev - Re: [PATCH v2] tcp: syncookies: do not use getnstimeofday()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140320.153645.1726836204043973392.davem@davemloft.net>
Date:	Thu, 20 Mar 2014 15:36:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH v2] tcp: syncookies: do not use getnstimeofday()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 19 Mar 2014 21:02:21 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While it is true that getnstimeofday() uses about 40 cycles if TSC
> is available, it can use 1600 cycles if hpet is the clocksource.
> 
> Switch to get_jiffies_64(), as this is more than enough, and
> go back to 60 seconds periods.
> 
> Fixes: 8c27bd75f04f ("tcp: syncookies: reduce cookie lifetime to 128 seconds")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Florian Westphal <fw@...len.de>

This applies cleanly to net-next, but with this Fixes: tag I sort of
suspect you are targetting this at net instead?

Please be explicit as to what the target tree is when submitting
patches in the future.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html