netdev - Re: [PATCH v3] sh_eth: ensure pm_runtime cannot suspend the device during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <532B5773.7020700@codethink.co.uk>
Date:	Thu, 20 Mar 2014 22:02:43 +0100
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	linux-kernel@...ts.codethink.co.uk, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v3] sh_eth: ensure pm_runtime cannot suspend the device
 during init

On 20/03/14 20:09, Sergei Shtylyov wrote:
> Hello.
>
> On 03/20/2014 09:01 PM, Laurent Pinchart wrote:
>
>>> The pm_rumtime work queue is causing the device to be suspended during
>>> initialisation, thus the initialisation may not be able to access
>>> registers
>>> properly. As the code is called from a work queue, it is possible
>>> that this
>>> is not seen from certain configurations/builds due to the asynchronos
>>> nature of the code.
>
>>> Another issue has also been found where the network device registration
>>> calls back into the driver thus causing further pm_runtime calls that
>>> also caused issues with the MDIO bus code.
>
>>> Use pm_runtime_get_sync() and pm_runtime_put() to ensure that the
>>> pm system does not suspend it during the probe() call and remove the
>>> now unnecessary pm_runtime_resume() call.
>
>>> This fixes the external abort that can cause /sbin/init or other such
>>> init processed to die.
>
>>> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
>>> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
>>> ---
>>> Cc: sergei.shtylyov@...entembedded.com
>>> Cc: laurent.pinchart+renesas@...asonboard.com
>>> cc: netdev@...r.kernel.org
>
>>> Note, Laurent this should probably be applied before your
>>> current series as it may require changes to the exit sequence.
>
>> Would you like me to include the patch in that series when I'll send a
>> pull
>> request ?
>
>>> Fixes from v1:
>>>     - use pm_runtime_put() over pm_runtime_put_sync() as
>>>       we do not need to guaranteed the device has powered
>>>            off after probe.
>
>>> Fixed from v2:
>>>     - call pm_runtime_put() in error path

Thanks, that looks like another issue that got missed.
I will submit v3


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html