netdev - Re: [PATCH] netpoll: fix the skb check in pkt_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Mwa_De9_vY32LdqxPDQqUnd6vBXMxh1jA2+s1kWNuD6A@mail.gmail.com>
Date:	Fri, 21 Mar 2014 09:47:26 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	roy.qing.li@...il.com
Cc:	netdev <netdev@...r.kernel.org>, Cong Wang <amwang@...hat.com>
Subject: Re: [PATCH] netpoll: fix the skb check in pkt_is_ns

On Fri, Mar 21, 2014 at 5:53 AM,  <roy.qing.li@...il.com> wrote:
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index a664f78..df9e6b1 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -742,7 +742,7 @@ static bool pkt_is_ns(struct sk_buff *skb)
>         struct nd_msg *msg;
>         struct ipv6hdr *hdr;
>
> -       if (skb->protocol != htons(ETH_P_ARP))
> +       if (skb->protocol != htons(ETH_P_IPV6))

But this code was just removed by:

commit 9c62a68d13119a1ca9718381d97b0cb415ff4e9d
Author: Eric W. Biederman <ebiederm@...ssion.com>
Date:   Fri Mar 14 20:51:52 2014 -0700

    netpoll: Remove dead packet receive code (CONFIG_NETPOLL_TRAP)


Or your patch is for -net? But CONFIG_NETPOLL_TRAP doesn't
have any in-tree users, so we probably don't care.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html