netdev - RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84837c9e73f24bcd8f652a24f616ff1e@DFM-DB3MBX15-06.exchange.corp.microsoft.com>
Date:	Fri, 21 Mar 2014 19:12:43 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
Subject: RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive
 Side Scaling (vRSS)



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Friday, March 21, 2014 2:55 PM
> To: Haiyang Zhang
> Cc: netdev@...r.kernel.org; KY Srinivasan; olaf@...fle.de;
> jasowang@...hat.com; linux-kernel@...r.kernel.org; driverdev-
> devel@...uxdriverproject.org
> Subject: Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
> 
> From: David Miller <davem@...emloft.net>
> Date: Fri, 21 Mar 2014 14:49:57 -0400 (EDT)
> 
> > From: Haiyang Zhang <haiyangz@...rosoft.com>
> > Date: Thu, 20 Mar 2014 15:28:41 -0700
> >
> >> This feature allows multiple channels to be used by each virtual NIC.
> >> It is available on Hyper-V host 2012 R2.
> >>
> >> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> >> Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> >
> > Applied, thanks.
> 
> Actually I had to revert, this doesn't even compile.
> 
> drivers/net/hyperv/netvsc.c: In function ‘netvsc_channel_cb’:
> drivers/net/hyperv/netvsc.c:891:2: error: implicit declaration of
> function ‘get_per_channel_state’ [-Werror=implicit-function-declaration]
> drivers/net/hyperv/netvsc.c:891:9: warning: assignment makes pointer
> from integer without a cast [enabled by default]
> drivers/net/hyperv/netvsc.c: In function ‘netvsc_device_add’:
> drivers/net/hyperv/netvsc.c:998:2: error: implicit declaration of
> function ‘set_per_channel_state’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/net/hyperv/netvsc.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> drivers/net/hyperv/rndis_filter.c: In function ‘netvsc_sc_open’:
> drivers/net/hyperv/rndis_filter.c:988:2: error: implicit declaration of
> function ‘set_per_channel_state’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/net/hyperv/rndis_filter.o] Error 1
> make[2]: *** [drivers/net/hyperv] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/net] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2

The per channel state variable and functions are defined by this patch,
which has been applied on 2/07:
Drivers: hv: vmbus: Support per-channel driver state
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8a7206a89f85c8439561b0eff85bb9440a2e97a9

Could it be merged into net-next tree?

Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html