netdev - Re: [PATCH iproute2] htb: Move direct_qlen code part to htb_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140321142050.48124da9@nehalam.linuxnetplumber.net>
Date:	Fri, 21 Mar 2014 14:20:50 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] htb: Move direct_qlen code part to
 htb_parse_opt().

On Sat, 8 Mar 2014 22:10:03 +0900
Hiroaki SHIMODA <shimoda.hiroaki@...il.com> wrote:

> The direct_qlen command option is used with qdisc operation.
> It happened to be implemented in htb_parse_class_opt() which is called
> with class operation.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> ---
> When I read the commit b43f3318280a ("htb: add support for direct_qlen attribute")
> I supposed to direct_qlen option is for htb leaf qdisc. But
> TCA_HTB_DIRECT_QLEN is parsed in htb_init() and also according
> to the command help of htb, I thought direct_qlen was accidentally
> implemented in htb_parse_class_opt().
> Sorry if I miss something.
> 
>  tc/q_htb.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Applied

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html