netdev - Re: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140321110423.GN23372@e106331-lin.cambridge.arm.com>
Date:	Fri, 21 Mar 2014 11:04:23 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Byungho An <bh74.an@...sung.com>
Cc:	"'netdev'" <netdev@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"'David Miller'" <davem@...emloft.net>,
	"'GIRISH K S'" <ks.giri@...sung.com>,
	"'SIVAREDDY KALLAM'" <siva.kallam@...sung.com>,
	"'Vipul Chandrakant'" <vipul.pandya@...sung.com>,
	"'Ilho Lee'" <ilho215.lee@...sung.com>
Subject: Re: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet)
 for Samsung sxgbe

On Thu, Mar 20, 2014 at 05:26:06PM +0000, Byungho An wrote:
> From: Girish K S <ks.giri@...sung.com>
> 
> Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver.
> 
> Signed-off-by: Girish K S <ks.giri@...sung.com>
> Neatening-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Byungho An <bh74.an@...sung.com>
> ---
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h  |   53 +++++++
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c    |   86 +++++++++-
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c |   47 ++++++
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c    |  165 +++++++++++++++++++-
>  .../net/ethernet/samsung/sxgbe/sxgbe_platform.c    |    4 +
>  drivers/net/ethernet/samsung/sxgbe/sxgbe_reg.h     |    5 +
>  6 files changed, 358 insertions(+), 2 deletions(-)

[...]

> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> index e410d84..b23ec57 100644
> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> @@ -160,6 +160,10 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
>                 }
>         }
> 
> +       priv->lpi_irq = irq_of_parse_and_map(dev->of_node, loop++);

You can use platform_get_irq(pdev, loop++) here. The interrupts have
already been parsed elsewhere.

Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html