lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Mar 2014 00:50:10 -0400 (EDT) From: David Miller <davem@...emloft.net> To: rgb@...hat.com Cc: linux-audit@...hat.com, linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, eparis@...hat.com, sgrubb@...hat.com, hadi@...atatu.com Subject: Re: [PATCH] netlink: have netlink per-protocol bind function return an error code. From: Richard Guy Briggs <rgb@...hat.com> Date: Fri, 21 Mar 2014 12:39:11 -0400 > @@ -1441,6 +1441,17 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr, > if (!nladdr->nl_groups && (nlk->groups == NULL || !(u32)nlk->groups[0])) > return 0; > > + if (nlk->netlink_bind && nladdr->nl_groups) { > + int i; > + > + for (i = 0; i < nlk->ngroups; i++) > + if (test_bit(i, (long unsigned int *)&nladdr->nl_groups)) { > + err = nlk->netlink_bind(i); > + if (err) > + return err; > + } > + } > + You can't just leave a partially set of completed bindings in place. It's not valid to leave half-baked state like this. If you return an error, all of the binding state changes must be completely undone. If you can't find a way to do this cleanly, you'll need to find a way for the audit code to not return an error. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists