netdev - Re: [PATCH net] tipc: fix spinlock recursion bug for failed subscriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140324.153731.470773468265097037.davem@davemloft.net>
Date:	Mon, 24 Mar 2014 15:37:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	erik.hugne@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com,
	paul.gortmaker@...driver.com, richard.alpe@...csson.com
Subject: Re: [PATCH net] tipc: fix spinlock recursion bug for failed
 subscriptions

From: <erik.hugne@...csson.com>
Date: Mon, 24 Mar 2014 16:56:38 +0100

> From: Erik Hugne <erik.hugne@...csson.com>
> 
> If a topology event subscription fails for any reason, such as out
> of memory, max number reached or because we received an invalid
> request the correct behavior is to terminate the subscribers
> connection to the topology server. This is currently broken and
> produces the following oops:
 ...
> The recursion occurs when subscr_terminate tries to grab the
> subscriber lock, which is already taken by subscr_conn_msg_event.
> We fix this by checking if the request to establish a new
> subscription was successful, and if not we initiate termination of
> the subscriber after we have released the subscriber lock.
> 
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html