netdev - Re: [PATCH net-next] i40e: i40evf: fix error checking path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Mar 2014 13:21:48 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	Mitch Williams <mitch.a.williams@...el.com>
Subject: Re: [PATCH net-next] i40e: i40evf: fix error checking path

On Sun, 2014-03-23 at 14:26 -0600, Jean Sacren wrote:
> The commit 6494294f277fd ("i40e/i40evf: Use
> dma_set_mask_and_coherent") uses dma_set_mask_and_coherent() to
> replace dma_set_coherent_mask() for the benefit of return error.
> The conversion brings some confusion in error checking as whether
> against DMA_BIT_MASK(64) or DMA_BIT_MASK(32). For one, if error is
> zero, the check will be against DMA_BIT_MASK(64) twice. Fix this
> error checking by binding the check to the pertinent one.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Mitch Williams <mitch.a.williams@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c     | 11 ++++++-----
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 11 ++++++-----
>  2 files changed, 12 insertions(+), 10 deletions(-)

Thanks Jean, I have added this to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)