netdev - Re: [PATCH] netlink: simplify nfnetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140324111044.GC5074@localhost>
Date:	Mon, 24 Mar 2014 12:10:44 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	eparis@...hat.com, sgrubb@...hat.com, hadi@...atatu.com,
	davem@...emloft.net
Subject: Re: [PATCH] netlink: simplify nfnetlink_bind

On Fri, Mar 21, 2014 at 12:44:09PM -0400, Richard Guy Briggs wrote:
> Remove duplicity and simplify code flow by moving the rcu_read_unlock() above
> the condition and let the flow control exit naturally at the end of the
> function.
> 
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
>  net/netfilter/nfnetlink.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> index 046aa13..75619f9 100644
> --- a/net/netfilter/nfnetlink.c
> +++ b/net/netfilter/nfnetlink.c
> @@ -399,12 +399,10 @@ static void nfnetlink_bind(int group)
>  
>  	rcu_read_lock();
>  	ss = nfnetlink_get_subsys(type);
> +	rcu_read_unlock();
>  	if (!ss) {
> -		rcu_read_unlock();
>  		request_module("nfnetlink-subsys-%d", type);
> -		return;
>  	}
> -	rcu_read_unlock();

Applied with minor glitch. Removed the brackets in that if branch.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html