netdev - [PATCH v2 0/2] net: davinci_emac: Fix interrupt requests and error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffba6fa2-5a11-41b0-a310-12250e104405@mary.at.omicron.at>
Date:	Mon, 24 Mar 2014 13:46:25 +0100
From:	Christian Riesch <christian.riesch@...cron.at>
To:	<netdev@...r.kernel.org>
CC:	Florian Fainelli <f.fainelli@...il.com>,
	Prabhakar Lad <prabhakar.csengg@...il.com>,
	Mugunthan V N <mugunthanvnm@...com>,
	David Miller <davem@...emloft.net>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Jon Ringle <jon@...gle.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Christian Riesch <christian.riesch@...cron.at>
Subject: [PATCH v2 0/2] net: davinci_emac: Fix interrupt requests and error handling

Hi,

since commit 6892b41d9701283085b655c6086fb57a5d63fa47 (Linux 3.11) the
davinci_emac driver is broken. After doing ifconfig down, ifconfig up,
requesting the interrupts for the driver fails. The interface remains dead
until the board is rebooted.

The first patch in this patchset reverts commit
6892b41d9701283085b655c6086fb57a5d63fa47 partially and makes the driver
useable again.

During the work on the first patch, a number of bugs in the error handling
of the driver's ndo_open code were found. The second patch fixes these bugs.

I believe the first patch meets the rules for stable kernels, I therefore added
the stable tag to this patch. The second patch is just cleanup, the code
that is fixed by this patch is only executed in case of an error.

Best regards,
Christian

Changes for v2:
- Added a longer commit message to the second patch, explaining the problems
  more detailed.

Christian Riesch (2):
  net: davinci_emac: Replace devm_request_irq with request_irq
  net: davinci_emac: Fix rollback of emac_dev_open()

 drivers/net/ethernet/ti/davinci_cpdma.c |    4 +--
 drivers/net/ethernet/ti/davinci_emac.c  |   53 ++++++++++++++++++++++++-------
 2 files changed, 44 insertions(+), 13 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html