netdev - Re: [PATCH 11/54] atl1c: Call dev_kfree/consume_skb_any instead of dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395753501.12610.119.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 25 Mar 2014 06:18:21 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH 11/54] atl1c: Call dev_kfree/consume_skb_any instead of
 dev_kfree_skb.

On Mon, 2014-03-24 at 23:04 -0700, Eric W. Biederman wrote:
> From: "Eric W. Biederman" <ebiederm@...ssion.com>
> 
> The call path: atl1c_xmit_frame, atlc_tx_rollback, atl1c_clean_buffer
> can not be tell at compile time if it will be invoked from hard irq
> or other context, as atl1c_xmit_frame does not know.  So remove
> the logic that  passes the compile time knowledge into al1c_clean_buffer
> and figure out it out at runtime with dev_consume_skb_any.
> 
> Replace dev_kfree_skb with dev_kfree_skb_any in atl1c_xmit_frame that
> can be called in hard irq and other contexts.
> 
> Replace dev_kfree_skb and dev_kfree_skb_irq with dev_consume_skb_any
> in atl1c_clean_buffer that can be called in hard irq and other
> contexts.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---

Nice ;)

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html