netdev - Re: [PATCH 15/54] cxgb3: Call dev_kfree/consume_skb_any instead of [dev_]kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395760687.12610.134.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 25 Mar 2014 08:18:07 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH 15/54] cxgb3: Call dev_kfree/consume_skb_any instead of
 [dev_]kfree_skb.

On Mon, 2014-03-24 at 23:05 -0700, Eric W. Biederman wrote:
> From: "Eric W. Biederman" <ebiederm@...ssion.com>
> 
> Replace kfree_skb with dev_consume_skb_any in free_tx_desc, and
> write_tx_pkt_wr that can be called in hard irq and other contexts.
> 
> Replace dev_kfree_skb with dev_kfree_skb_any in t3_eth_xmit that can
> be called in hard irq and other contexts.
> 
> dev_kfree_skb is replaced with dev_kfree_skb_any in t3_eth_xmit as
> that location is a packet drop, while kfree_skb in free_tx_desc,
> and in write_tx_pkt_wr are places where packets are consumed
> in a healthy manner.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html