netdev - Re: [PATCH net-next 3/3] ipv6: fix checkpatch errors of foo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5331BEF6.5030900@cogentembedded.com>
Date:	Tue, 25 Mar 2014 20:37:58 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Wangyufen <wangyufen@...wei.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] ipv6: fix checkpatch errors of foo

Hello.

On 03/25/2014 05:44 AM, Wangyufen wrote:

> From: Wang Yufen <wangyufen@...wei.com>

> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"

> Signed-off-by: Wang Yufen <wangyufen@...wei.com>
> ---
>   net/ipv6/ip6_fib.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)

> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index 8cb6949..22acde8 100644
> --- a/net/ipv6/ip6_fib.c
> +++ b/net/ipv6/ip6_fib.c
[...]
> @@ -951,7 +951,7 @@ struct lookup_args {
>   	const struct in6_addr	*addr;		/* search key			*/
>   };
>
> -static struct fib6_node * fib6_lookup_1(struct fib6_node *root,
> +static struct fib6_node *fib6_lookup_1(struct fib6_node *root,
>   					struct lookup_args *args)

    Reindent the above line please, so that it still starts under *struct* on 
the previous line.

[...]
> @@ -1014,7 +1014,7 @@ backtrack:
>   	return NULL;
>   }
>
> -struct fib6_node * fib6_lookup(struct fib6_node *root, const struct in6_addr *daddr,
> +struct fib6_node *fib6_lookup(struct fib6_node *root, const struct in6_addr *daddr,
>   			       const struct in6_addr *saddr)

    Likewise.

[...]
> @@ -1047,7 +1047,7 @@ struct fib6_node * fib6_lookup(struct fib6_node *root, const struct in6_addr *da
>    */
>
>
> -static struct fib6_node * fib6_locate_1(struct fib6_node *root,
> +static struct fib6_node *fib6_locate_1(struct fib6_node *root,
>   					const struct in6_addr *addr,
>   					int plen, int offset)

    Likewise.

[...]
> @@ -1077,7 +1077,7 @@ static struct fib6_node * fib6_locate_1(struct fib6_node *root,
>   	return NULL;
>   }
>
> -struct fib6_node * fib6_locate(struct fib6_node *root,
> +struct fib6_node *fib6_locate(struct fib6_node *root,
>   			       const struct in6_addr *daddr, int dst_len,
>   			       const struct in6_addr *saddr, int src_len)

    Likewise.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html