netdev - Re: [PATCH net-next v3 3/3] bonding: add net_ratelimt to avoid spam in arp interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140325072935.GA1476@redhat.com>
Date:	Tue, 25 Mar 2014 08:29:35 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	fubar@...ibm.com, andy@...yhouse.net, joe@...ches.com,
	kaber@...sh.net, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/3] bonding: add net_ratelimt to avoid spam
 in arp interval

On Tue, Mar 25, 2014 at 11:21:37AM +0800, Ding Tianhong wrote:
...snip...
>-	pr_debug("arp %d on slave %s: dst %pI4 src %pI4\n",
>-		 arp_op, slave_dev->name, &dest_ip, &src_ip);
>+	net_dbg_ratelimited("arp %d on slave %s: dst %pI4 src %pI4\n",
>+			    arp_op, slave_dev->name, &dest_ip, &src_ip);

I don't think we should ratelimit debug statements - as they're turned on
only when the user is actually debugging, so that all the debug statements
should be shown.

As an example here - I actually used it and grepped for a specific arp. If
it was ratelimited - I might have skipped it.

> 	if (outer->vlan_id) {
> 		if (inner->vlan_id) {
>-			pr_debug("inner tag: proto %X vid %X\n",
>-				 ntohs(inner->vlan_proto), inner->vlan_id);
>+			net_dbg_ratelimited("inner tag: proto %X vid %X\n",
>+					    ntohs(inner->vlan_proto),
>+					    inner->vlan_id);

Same here.

>-		pr_debug("outer reg: proto %X vid %X\n",
>-			 ntohs(outer->vlan_proto), outer->vlan_id);
>+		net_dbg_ratelimited("outer reg: proto %X vid %X\n",
>+				     ntohs(outer->vlan_proto), outer->vlan_id);

And here.

>-			if (bond->params.arp_validate && net_ratelimit())
>-				pr_warn("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
>-					bond->dev->name, &targets[i]);
>+			if (bond->params.arp_validate)
>+				net_dbg_ratelimited("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
>+						    bond->dev->name,
>+						    &targets[i]);

You've changed an already ratelimited warning with a debug statement. This
warning is here for a reason.

>-		pr_debug("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
>-			 bond->dev->name, &targets[i],
>-			 rt->dst.dev ? rt->dst.dev->name : "NULL");
>+		net_dbg_ratelimited("%s: no path to arp_ip_target %pI4 via rt.dev %s\n",
>+				    bond->dev->name, &targets[i],
>+				    rt->dst.dev ? rt->dst.dev->name : "NULL");

Again the dbg ratelimit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html