netdev - RE: [PATCH net-next 4/7] qlcnic: Remove casts of pointer to same type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A46F809CB@avmb2.qlogic.org>
Date:	Tue, 25 Mar 2014 05:50:38 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Joe Perches <joe@...ches.com>, netdev <netdev@...r.kernel.org>
CC:	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 4/7] qlcnic: Remove casts of pointer to same
 type

> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Tuesday, March 25, 2014 1:46 AM
> To: netdev
> Cc: Shahed Shaikh; Dept-HSG Linux NIC Dev; linux-kernel
> Subject: [PATCH net-next 4/7] qlcnic: Remove casts of pointer to same type
> 
> Casting a pointer to a pointer of the same type is pointless, so remove these
> unnecessary casts.
> 
> Done via coccinelle script:
> 
> $ cat typecast_2.cocci
> @@
> type T;
> T *foo;
> @@
> 
> -	(T *)foo
> +	foo
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Shahed Shaikh <shahed.shaikh@...gic.com>

Thanks,
Shahed
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> index ec399b7..2d91975 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> @@ -1388,7 +1388,7 @@ static int qlcnic_83xx_copy_fw_file(struct
> qlcnic_adapter *adapter)
>  	addr = (u64)dest;
> 
>  	ret = qlcnic_83xx_ms_mem_write128(adapter, addr,
> -					  (u32 *)p_cache, size / 16);
> +					  p_cache, size / 16);
>  	if (ret) {
>  		dev_err(&adapter->pdev->dev, "MS memory write
> failed\n");
>  		release_firmware(fw);
> --
> 1.8.1.2.459.gbcd45b4.dirty

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html