netdev - Re: [PATCH net-next 2/3] bonding: ratelimit pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53313A7B.7040802@huawei.com>
Date:	Tue, 25 Mar 2014 16:12:43 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Joe Perches <joe@...ches.com>
CC:	<fubar@...ibm.com>, <vfalico@...hat.com>, <andy@...yhouse.net>,
	<kaber@...sh.net>, <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] bonding: ratelimit pr_err() for bond xmit
 broadcast

On 2014/3/25 15:19, Joe Perches wrote:
> On Tue, 2014-03-25 at 15:03 +0800, Ding Tianhong wrote:
>> It may spam if the system is out of the memory, add ratelimit for it.
> 
> Sorry, I didn't follow whatever discussion occurred here.
> 
> I thought you were going to use net_err_ratelimited
> for these?
> 
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> []
>> @@ -3656,8 +3656,8 @@ static int bond_xmit_broadcast(struct sk_buff *skb, struct net_device *bond_dev)
>> -				pr_err("%s: Error: bond_xmit_broadcast(): skb_clone() failed\n",
>> -				       bond_dev->name);
>> +				pr_err_ratelimited("%s: Error: bond_xmit_broadcast(): skb_clone() failed\n",
>> +						   bond_dev->name);
> 
> also btw, it's better I think to use
> %s, __func__ instead of embedding
> explicit function names
> 
> 
> 
Yes, maybe I still didn't clear when to use net_err_ratelimited, thanks.

Ding



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html