netdev - Re: [PATCH v2 net 1/2] net: Allow modules to use is_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2014 22:18:33 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Vlad Yasevich <vyasevic@...hat.com>, netdev@...r.kernel.org
CC:	bridge@...ts.linux-foundation.org, shemminger@...tta.com
Subject: Re: [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable

Hello.

On 03/26/2014 07:14 PM, Vlad Yasevich wrote:

> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
[...]

> diff --git a/net/core/dev.c b/net/core/dev.c
> index b1b0c8d..a98f7fa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct sk_buff *skb)
>   			__net_timestamp(SKB);		\
>   	}						\
>
> -static inline bool is_skb_forwardable(struct net_device *dev,
> +bool is_skb_forwardable(struct net_device *dev,
>   				      struct sk_buff *skb)

    Please re-indent the above line, so that it still starts under *struct*.

>   {
>   	unsigned int len;

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html