netdev - Re: [PATCH net-next] tcp: tcp_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140326.142551.19958322633174107.davem@davemloft.net>
Date:	Wed, 26 Mar 2014 14:25:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: tcp_make_synack() minor changes

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 26 Mar 2014 09:57:19 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There is no need to allocate 15 bytes in excess for a SYNACK packet,
> as it contains no data, only headers.
> 
> SYNACK are always generated in softirq context, and contain a single
> segment, we can use TCP_INC_STATS_BH()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
 ...
> -	skb = sock_wmalloc(sk, MAX_TCP_HEADER + 15, 1, GFP_ATOMIC);
> +	skb = sock_wmalloc(sk, MAX_TCP_HEADER, 1, GFP_ATOMIC);

Do you know where this "+ 15" comes from? :-)

It is a kind of Linux networking trivia question.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html