netdev - Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140326.161242.576245997077162750.davem@davemloft.net>
Date:	Wed, 26 Mar 2014 16:12:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	zoltan.kiss@...rix.com
Cc:	jesse@...ira.com, pshelar@...ira.com, tgraf@...hat.com,
	dev@...nvswitch.org, pablo@...filter.org, kadlec@...ckhole.kfki.hu,
	edumazet@...gle.com, dborkman@...hat.com, therbert@...gle.com,
	jasowang@...hat.com, fw@...len.de, joe@...ches.com,
	horms@...ge.net.au, jiri@...nulli.us, mst@...hat.com,
	Paul.Durrant@...rix.com, JBeulich@...e.com,
	herbert@...dor.apana.org.au, mszeredi@...e.cz,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v4] core, nfqueue, openvswitch: Orphan frags in
 skb_zerocopy and handle errors

From: David Miller <davem@...emloft.net>
Date: Wed, 26 Mar 2014 15:59:58 -0400 (EDT)

> From: Zoltan Kiss <zoltan.kiss@...rix.com>
> Date: Fri, 21 Mar 2014 10:31:34 +0000
> 
>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>> as well, and modify the callers accordingly. skb_tx_error() is also added to
>> the callers so they will signal the failed delivery towards the creator of the
>> skb.
>> 
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com>
> 
> Applied, thanks Zoltan.

Actually, Zoltan, you have to fix this:

net/core/skbuff.c: In function ‘skb_zerocopy’:
net/core/skbuff.c:2172:2: warning: passing argument 1 of ‘skb_orphan_frags’ discards ‘const’ qualifi
er from pointer target type [enabled by default]
In file included from include/linux/tcp.h:21:0,
                 from net/core/skbuff.c:50:
include/linux/skbuff.h:1904:19: note: expected ‘struct sk_buff *’ but argument is of type ‘const str
uct sk_buff *’
net/core/skbuff.c:2173:3: warning: passing argument 1 of ‘skb_tx_error’ discards ‘const’ qualifier f
rom pointer target type [enabled by default]
net/core/skbuff.c:642:6: note: expected ‘struct sk_buff *’ but argument is of type ‘const struct sk_
buff *’