netdev - Re: [net-next 11/15] i40e: Add a fallback debug flow for the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140326.171722.1680025627362836425.davem@davemloft.net>
Date:	Wed, 26 Mar 2014 17:17:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	anjali.singhai@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, catherine.sullivan@...el.com
Subject: Re: [net-next 11/15] i40e: Add a fallback debug flow for the driver

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 26 Mar 2014 11:03:29 -0700

> From: Anjali Singhai Jain <anjali.singhai@...el.com>
> 
> If the reset fails or the FW is unresponsive instead of failing
> module load, load the module in debug mode. In this mode the interfaces
> don't exit but the user gets limited access to debugfs hooks. These can
> still be used to read/write to registers for debug.
> 
> Change-ID: Ie33da80d2f53aaa18eac816196d981fb7a86a02c
> Signed-off-by: Anjali Singhai Jain <anjali.singhai@...el.com>
> Signed-off-by: Catherine Sullivan <catherine.sullivan@...el.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

We had this discussion.

Register read/write does not belong in debugfs, utilize a portable existing
typed interface to provide this.  Or create one if it doesn't already
exist.

I think you guys put way too much stuff into your debugfs facilities that
really belong in portable interfaces that any driver can mimick.

Do we really want _EVERY_ driver to add register read/write hack code,
duplicated over and over, via debugfs like this?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html