netdev - Re: [PATCH 2/7] atm: replace del_timer by del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395873117.12610.269.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 26 Mar 2014 15:31:57 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vijay Subramanian <subramanian.vijay@...il.com>
Cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	"David S. Miller" <davem@...emloft.net>,
	kernel-janitors@...r.kernel.org, tglx@...utronix.de,
	netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

On Wed, 2014-03-26 at 15:19 -0700, Vijay Subramanian wrote:
> >
> > It seems this timer rearms itself, so this patch wont be enough I fear.
> >
> >
> >
> Does that matter? It seems del_timer_sync() may be intended to work
> despite this (i.e. timer will not fire after call to this function).
> My earlier attempt to fix a similar issue in sch_red.c resulted in
> this explanation.
> http://www.spinics.net/lists/netdev/msg256410.html

I know this very well, thank you.

If documentation is stale, it needs clarification.

If not, we need to make sure timer wont be restarted.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html