netdev - Re: [PATCH net-next resend] net/mlx4_core: pass pci_device_id.driver_data to __mlx4_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2014 18:02:27 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>, jackm@....mellanox.co.il,
	ogerlitz@...lanox.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next resend] net/mlx4_core: pass pci_device_id.driver_data
 to __mlx4_init_one during reset

Hello.

On 26-03-2014 14:15, Wei Yang wrote:

> [Note: seems my network/mail system got some problem yesterday. Resend it in
> case it is lost. If you have already got one, please ignore it.]

    Put such remarks under --- tear line in the future, so that David don't 
have to edit them out when applying.

> The second parameter of __mlx4_init_one() is used to identify whether the
> pci_dev is a PF or VF. Currently, when it is invoked in mlx4_pci_slot_reset()
> this information is missed.

> This patch match the pci_dev with mlx4_pci_table and passes the
> pci_device_id.driver_data to __mlx4_init_one() in mlx4_pci_slot_reset().

> Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index d711158..b083808 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -2670,7 +2670,11 @@ static pci_ers_result_t mlx4_pci_err_detected(struct pci_dev *pdev,
>
>   static pci_ers_result_t mlx4_pci_slot_reset(struct pci_dev *pdev)
>   {
> -	int ret = __mlx4_init_one(pdev, 0);
> +	const struct pci_device_id*  id;

    * should be close to 'id' and one space is enough. I guess you haven't run 
your patch thru scripts/checkpatch.pl?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html