netdev - Re: [PATCH] netfilter: nf_conntrack: reserve two bytes for nf_ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140327160100.GA32534@macbook.localnet>
Date:	Thu, 27 Mar 2014 16:01:01 +0000
From:	Patrick McHardy <kaber@...sh.net>
To:	Florian Westphal <fw@...len.de>
Cc:	Andrey Vagin <avagin@...nvz.org>, linux-kernel@...r.kernel.org,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	coreteam@...filter.org, netdev@...r.kernel.org, vvs@...allels.com,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] netfilter: nf_conntrack: reserve two bytes for
 nf_ct_ext->len

On Thu, Mar 27, 2014 at 04:50:33PM +0100, Florian Westphal wrote:
> Andrey Vagin <avagin@...nvz.org> wrote:
> > "len" contains sizeof(nf_ct_ext) and size of extensions. In a worst
> > case it can contain all extensions. Bellow you can find sizes for all
> > types of extensions. Their sum is definitely bigger than 256.
> > 
> > nf_ct_ext_types[0]->len = 24
> > nf_ct_ext_types[1]->len = 32
> > nf_ct_ext_types[2]->len = 24
> > nf_ct_ext_types[3]->len = 32
> > nf_ct_ext_types[4]->len = 152
> 
> Guess its  the timer in the ecache extension (with LOCKDEP on probably).
> 
> I'll submit a patch to get rid of that shortly.
> 
> I think your patch is fine because the 'no timer
> in ecache extension' change is quite large, needs review/stress testing
> etc and is inapropriate for stable tree anyway.
> 
> > I have seen "len" up to 280 and my host has crashes w/o this patch.
> 
> ecache is 24 bytes without that timer, should be < 256 in total for
> all extensions.
> 
> I think BUILD_BUG_ON test would be nice.

We also have variable length extensions, but we definitely should catch
this *somewhere*.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html