netdev - Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140327.130604.103963458048959251.davem@davemloft.net>
Date:	Thu, 27 Mar 2014 13:06:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	ben@...adent.org.uk, john.r.fastabend@...el.com, kaber@...sh.net,
	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net v2] vlan: Fix lockdep warning when vlan dev handle
 notification

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Mon, 17 Mar 2014 11:08:37 +0800

> On 2014/3/15 10:02, David Miller wrote:
>> From: Ding Tianhong <dingtianhong@...wei.com>
>> Date: Thu, 13 Mar 2014 10:22:18 +0800
>> 
>>> When I open the LOCKDEP config and run these steps:
>> 
>> This doesn't work?
>> 
> 
> It make no sense, I have try it before, the class check only focus on the lock_class_key,
> not the lockdep_subclass_key.

I think the issue is that not all of the addrlist locking uses _nested() variants,
I think if we do that, this will all work.

I do not want to add a huge array of locking keys to fix this, it's a waste of
static kernel memory and inelegant.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html