netdev - Re: [PATCH v2 net] vlan: Mask off vlan acceleration features on vlan device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Mar 2014 16:25:41 -0400
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH v2 net] vlan: Mask off vlan acceleration features on vlan
 device.

On 03/27/2014 03:12 PM, David Miller wrote:
> From: Vlad Yasevich <vyasevic@...hat.com>
> Date: Wed, 26 Mar 2014 16:28:31 -0400
> 
>> Some drivers incorrectly assign vlan acceleration features to
>> vlan_features thus causing issues for Q-in-Q vlan configurations.
>> Prevent this once and for all by masking off acceleration features
>> for vlan devices until such time as we support stacked acceleration.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> 
> Vlad, I've thought more about this, I'd rather we emit a warning so
> we can fix the drivers.
> 
> If they are setting the flags wrong, we probably want to go take a
> look to see if they are doing anything else related wrong too.
> 

OK.  I'll rework the patch to emit a warning.  I took a quick glance
through all the devices that set vlan_features and there are 3 more
the have vlan_features wrong.  I'll include those when I re-submit.

Thanks
-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html