netdev - Re: [PATCH v2 net] net: Account for all vlan headers in skb_mac_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395958890.12610.324.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 27 Mar 2014 15:21:30 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] net: Account for all vlan headers in
 skb_mac_gso_segment

On Thu, 2014-03-27 at 17:26 -0400, Vlad Yasevich wrote:

> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 869c7af..cac38ba 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -2866,8 +2866,9 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,
>  	int err = -ENOMEM;
>  	int i = 0;
>  	int pos;
> +	int dummy;
>  
> -	proto = skb_network_protocol(head_skb);
> +	proto = skb_network_protocol(head_skb, &dummy);
>  	if (unlikely(!proto))
>  		return ERR_PTR(-EINVAL);
>  

I am wondering if '&dummy' could be replaced by &doffset.

We have :

unsigned int doffset = head_skb->data - skb_mac_header(head_skb);

It looks like this is the same content than 'dummy', right ?




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html