netdev - RE: [PATCH net-next v3 2/2] be2net: csum, tso and rss steering offload support for VxLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Mar 2014 05:07:41 +0000
From:	Sathya Perla <Sathya.Perla@...lex.Com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v3 2/2] be2net: csum, tso and rss steering
 offload support for VxLAN

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> 
> From: Sathya Perla <sathya.perla@...lex.com>
> Date: Tue, 25 Mar 2014 19:20:30 +0530
> 
> > This patch mainly implements the add/del_vxlan_port() methods by invoking
> > the needed FW cmds for supporting VxLAN offloads for Skyhawk-R.
> >
> > Signed-off-by: Sathya Perla <sathya.perla@...lex.com>
> 
> I know Or Gerlitz mentioned sleeping and that's where this workqueue comes
> from, but please I'd say to not add this if it's not necessary.
> 
> be_cmd_set_profile_config() runs with a BH spinlock held during it's
> entirety, it will never sleep.
> 
> So please go back to what you were doing in the first revision of this
> patch and submit the command synchronously rather than via a workqueue.

:-) Ok, I'll send out a v4 patch-set. Thanks. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html