netdev - Re: [PATCH v5 net-next 0/2] patchset: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 01:39:30 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	VenkatKumar.Duvvuru@...lex.Com, netdev@...r.kernel.org
Subject: Re: [PATCH v5 net-next 0/2] patchset: Support for configurable RSS
 hash key

On Thu, 2014-03-27 at 14:53 -0400, David Miller wrote:
> From: Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
> Date: Wed, 26 Mar 2014 09:21:01 +0000
> 
> > I don't mind going back to the original approach of adding a new
> > hash key operation. Please let me know what you guys think, combined
> > operation or a new operation.
> 
> Unless Ben has a major objection, I would prefer that we just add a
> new hash key interface.

My objection is that there is also the prospect of having multiple RSS
contexts on a single device.  I think we discussed the usefulness of
that several years back at a netconf.  And there is now hardware that
supports it: at least the Solarflare SFC9100 controllers do, and I doubt
they are unique in this.

By grouping the key and hash together, with some reserved fields (which
the setter should initially require to be equal to zero), it should be
possible to fill in support for numbered RSS contexts later without yet
another new structure and operations.

Ben.

-- 
Ben Hutchings
Always try to do things in chronological order;
it's less confusing that way.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)