netdev - Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 11:19:34 -0700
From:	David Decotigny <decot@...glers.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	Jiri Pirko <jiri@...nulli.us>,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Weilong Chen <chenweilong@...wei.com>,
	Amir Vadai <amirv@...lanox.com>,
	Michael Dalton <mwdalton@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

Hi all,

Thank you all for your feedback. Indeed, these counters are meant to
detect link flapping situations, and we prefer to accumulate in the
kernel rather than doing it in user space based on the count of
up/down transitions. How about I update the patch with a new
IFLA_LINK_HEALTH that exposes the 2 counters as a new struct? Or: is
it safe/recommended for userspace backward-compatibility to append new
fields to structs like rtnl_link_statsX (I have the impression that
iproute2 would be ok with it)?

On Fri, Mar 28, 2014 at 11:08 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2014-03-28 at 10:59 -0700, Florian Fainelli wrote:
>
>> What I meant is that this sort of information most likely is already
>> part of some sort of machine health check that runs periodically,
>> which probably collects gazillions of other metrics. Whether the link
>> flapping information comes from sysfs or was maintained by a small
>> script which counts link UP/DOWN events from 'ip monitor link' and
>> outputs this into a file boils down to the same thing: the information
>> is available to some degree.
>
> Yeah, I am not sure such a daemon runs on my netgear/OpenWrt router ;)
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html