netdev - Re: [PATCH v5] sh_eth: ensure pm_runtime cannot suspend the device during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140328.142606.2032782733436495474.davem@davemloft.net>
Date:	Fri, 28 Mar 2014 14:26:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ben.dooks@...ethink.co.uk
Cc:	linux-kernel@...ts.codethink.co.uk, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	laurent.pinchart+renesas@...asonboard.com
Subject: Re: [PATCH v5] sh_eth: ensure pm_runtime cannot suspend the device
 during init

From: Ben Dooks <ben.dooks@...ethink.co.uk>
Date: Fri, 21 Mar 2014 12:09:14 +0100

> The pm_rumtime work queue is causing the device to be suspended during
> initialisation, thus the initialisation may not be able to access registers
> properly. As the code is called from a work queue, it is possible that this
> is not seen from certain configurations/builds due to the asynchronos
> nature of the code.
> 
> Another issue has also been found where the network device registration
> calls back into the driver thus causing further pm_runtime calls that
> also caused issues with the MDIO bus code. This has now been checked
> and is the only place the MDIO can be called without the device open.
> 
> Use pm_runtime_get_sync() and pm_runtime_put() to ensure that the
> pm system does not suspend it during the probe() call and remove the
> now unnecessary pm_runtime_resume() call. Also add a call in the error
> path to call pm_runtime_disable().
> 
> This fixes the external abort that can cause /sbin/init or other such
> init processed to die.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>

What tree is this against?  It doesn't apply cleanly to 'net'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html