netdev - Re: [PATCH net v3] random32: avoid attempt to late reseed if in the middle of seeding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 16:05:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	hannes@...essinduktion.org, netdev@...r.kernel.org,
	sasha.levin@...cle.com
Subject: Re: [PATCH net v3] random32: avoid attempt to late reseed if in
 the middle of seeding

From: Daniel Borkmann <dborkman@...hat.com>
Date: Fri, 28 Mar 2014 17:38:42 +0100

> From: Sasha Levin <sasha.levin@...cle.com>
> 
> Commit 4af712e8df ("random32: add prandom_reseed_late() and call when
> nonblocking pool becomes initialized") has added a late reseed stage
> that happens as soon as the nonblocking pool is marked as initialized.
> 
> This fails in the case that the nonblocking pool gets initialized
> during __prandom_reseed()'s call to get_random_bytes(). In that case
> we'd double back into __prandom_reseed() in an attempt to do a late
> reseed - deadlocking on 'lock' early on in the boot process.
> 
> Instead, just avoid even waiting to do a reseed if a reseed is already
> occuring.
> 
> Fixes: 4af712e8df99 ("random32: add prandom_reseed_late() and call when nonblocking pool becomes initialized")
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> ---
>  Recommended for -stable as well. I'm resending the patch as v2
>  from [1] does not apply to the tree, perhaps some mail client
>  issue ...
> 
>  [1] http://patchwork.ozlabs.org/patch/334223/

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html