netdev - Re: [PATCHv3] net: mvneta: use devm_ioremap_resource() instead of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140328.161007.1937376826264802047.davem@davemloft.net>
Date:	Fri, 28 Mar 2014 16:10:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.petazzoni@...e-electrons.com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	alior@...vell.com, gregory.clement@...e-electrons.com,
	ezequiel.garcia@...e-electrons.com
Subject: Re: [PATCHv3] net: mvneta: use devm_ioremap_resource() instead of
 of_iomap()

From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Date: Thu, 27 Mar 2014 11:39:29 +0100

> The mvneta driver currently uses of_iomap(), which has two drawbacks:
> it doesn't request the resource, and it isn't devm-style so some error
> handling is needed.
> 
> This commit switches to use devm_ioremap_resource() instead, which
> automatically requests the resource (so the I/O registers region shows
> up properly in /proc/iomem), and also is devm-style, which allows to
> get rid of some error handling to unmap the I/O registers region.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

Does this actually fix any bugs?  It seems like the unmaps happen in
all the necessary cases.

If it's just a simplification or cleanup I'm going to apply this to
net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html