netdev - Re: [PATCH net 1/2] bridge: Fix inabillity to retrieve vlan tags when tx offload is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140328.163336.1242033159764820959.davem@davemloft.net>
Date:	Fri, 28 Mar 2014 16:33:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	stephen@...workplumber.org, vyasevic@...hat.com,
	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net 1/2] bridge: Fix inabillity to retrieve vlan tags
 when tx offload is disabled

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Thu, 27 Mar 2014 21:46:55 +0900

> Bridge vlan code (br_vlan_get_tag()) assumes that all frames have vlan_tci
> if they are tagged, but if vlan tx offload is manually disabled on bridge
> device and frames are sent from vlan device on the bridge device, the tags
> are embedded in skb->data and they break this assumption.
> Extract embedded vlan tags and move them to vlan_tci at ingress.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html