netdev - Re: [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140328.171417.1243496360817986608.davem@davemloft.net>
Date:	Fri, 28 Mar 2014 17:14:17 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	makita.toshiaki@....ntt.co.jp
Subject: Re: [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Thu, 27 Mar 2014 21:51:18 -0400

> When the vlan filtering is enabled on the bridge, but
> the filter is not configured on the bridge device itself,
> running tcpdump on the bridge device will result in a
> an Oops with NULL pointer dereference.  The reason
> is that br_pass_frame_up() will bypass the vlan
> check because promisc flag is set.  It will then try
> to get the table pointer and process the packet based
> on the table.  Since the table pointer is NULL, we oops.
> Catch this special condition in br_handle_vlan().
> 
> Reported-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> CC: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> ---
> 
> * Changed to use kfree_skb() instead of kfree_skb_list() to
>   match the reset of bridge code.
> * Fix-up {} style.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html