netdev - Samsung sxgbe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <19617.1396041625@turing-police.cc.vt.edu>
Date:	Fri, 28 Mar 2014 17:20:25 -0400
From:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
To:	Siva Reddy Kallam <siva.kallam@...sung.com>,
	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Samsung sxgbe driver - Kconfig issue

commit 1edb9ca69e8a7988900fc0283e10550b5592164d
Author: Siva Reddy <siva.kallam@...sung.com>
Date:   Tue Mar 25 12:10:54 2014 -0700

    net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

    This patch adds support for Samsung 10Gb ethernet driver(sxgbe).


This commit added the following in the Kconfig file:

config NET_VENDOR_SAMSUNG
        bool "Samsung Ethernet device"
        default y
        ---help---
          This is the driver for the SXGBE 10G Ethernet IP block found on Samsung
          platforms.

Please redo this to match the style of other NET_VENDOR_FOO, and make clear
that it only selects a submenu.  For instance, drivers/net/ethernet/qlogic/Kconfig
says:

config NET_VENDOR_QLOGIC
        bool "QLogic devices"
        default y
        depends on PCI
        ---help---
          If you have a network (Ethernet) card belonging to this class, say Y
          and read the Ethernet-HOWTO, available from
          <http://www.tldp.org/docs.html#howto>.

          Note that the answer to this question doesn't directly affect the
          kernel: saying N will just cause the configurator to skip all
          the questions about QLogic cards. If you say Y, you will be asked for
          your specific card in the following questions.

if NET_VENDOR_QLOGIC




Content of type "application/pgp-signature" skipped