netdev - Re: [PATCH net 1/4] qlge: Do not propaged vlan tag offloads to vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BECD8E8A1B550B48A1BF97C13991F60E46D3C3AD@avmb2.qlogic.org>
Date:	Fri, 28 Mar 2014 03:32:23 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Vlad Yasevich <vyasevic@...hat.com>,
	netdev <netdev@...r.kernel.org>
CC:	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Ron Mercer <ron.mercer@...gic.com>
Subject: Re: [PATCH net 1/4] qlge: Do not propaged vlan tag offloads to vlans


On 3/27/14 7:14 PM, "Vlad Yasevich" <vyasevic@...hat.com> wrote:

>qlge driver turns off NETIF_F_HW_CTAG_FILTER, but forgets to
>turn off HW_CTAG_TX and HW_CTAG_RX on vlan devices.  With the
>current settings, q-in-q will only generate a single vlan header.
>Remember to mask off CTAG_TX and CTAG_RX features in vlan_features.
>
>CC: Shahed Shaikh <shahed.shaikh@...gic.com>
>CC: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
>CC: Ron Mercer <ron.mercer@...gic.com>
>Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
>---
> drivers/net/ethernet/qlogic/qlge/qlge_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html