netdev - Re: [PATCH net-next 05/17] ixgb: remove open-coded skb_cow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396098019.3616.1.camel@joe-AO722>
Date:	Sat, 29 Mar 2014 06:00:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [PATCH net-next 05/17] ixgb: remove open-coded skb_cow_head.

On Sat, 2014-03-29 at 05:47 -0700, Joe Perches wrote:
> On Sat, 2014-03-29 at 12:26 +0100, Francois Romieu wrote:
> > struct ixgb_adapter *adapter, struct sk_buff *skb)
> >         if (likely(skb_is_gso(skb))) {
> >                 struct ixgb_buffer *buffer_info;
> >                 struct iphdr *iph;
> > +               int err;
> >  
> > -               if (skb_header_cloned(skb)) {
> > -                       err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC);
> > -                       if (err)
> > -                               return err;
> > -               }
> > +               err = skb_cow_head(skb, 0);
> > +               if (err < 0)
> > +                       return err
> 
> It seems in many instances you're adding
> an unnecessary declaration of err that
> shadows an already declared err

I take back the many.  This seems to be the only one.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html