netdev - Re: [PATCH 1/3] net: Add a test to see if a skb is freeable in irq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140329.180945.1823589321953879448.davem@davemloft.net>
Date:	Sat, 29 Mar 2014 18:09:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	bjorn@...k.no, eric.dumazet@...il.com, ben@...adent.org.uk,
	stephen@...workplumber.org, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com,
	David.Laight@...LAB.COM
Subject: Re: [PATCH 1/3] net: Add a test to see if a skb is freeable in irq
 context

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Thu, 27 Mar 2014 18:15:47 -0700

> Currently netpoll and skb_release_head_state assume that a skb is
> freeable in hard irq context except when skb->destructor is set.
> 
> The reality is far from this.  So add a function skb_irq_freeable to
> compute the full test and in the process be the living documentation of
> what the requirements are of actually freeing a skb in hard irq context.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
 ...
> +	return !skb->destructor &&
> +#if IS_ENABLED(CONFIG_XFRM)
> +		!skb->sp &&
> +#endif
> +#if IS_ENABLED(CONFIG_NF_CONNTRACK)
> +		!skb->nfct &&
> +#endif
> +		!skb->_skb_refdst &&
> +		!skb_has_frag_list(skb);

I think you need to add "!skb->nf_bridge &&" to this test.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html