netdev - Re: [PATCH net] bridge: Fix memory leak in br_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1396147295.2182.12.camel@localhost.localdomain>
Date:	Sun, 30 Mar 2014 11:41:35 +0900
From:	Toshiaki Makita <toshiaki.makita1@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
	Vlad Yasevich <vyasevic@...hat.com>, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org,
	"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] bridge: Fix memory leak in br_dev_xmit

On Sat, 2014-03-29 at 16:40 +0900, Toshiaki Makita wrote:
> On Fri, 2014-03-28 at 09:34 -0700, Stephen Hemminger wrote:
> > On Fri, 28 Mar 2014 15:21:19 +0900
> > Toshiaki Makita <makita.toshiaki@....ntt.co.jp> wrote:
> > 
> > > When a frame is rejected by br_allowed_ingress(), the skb is not freed.
> > > 
> ...
> > Increment dev->tx_dropped?
> 
> OK, I'll rework it.

After investigating bridge codes, I found br_cpu_netstats doesn't have
tx_dropped field.
I'm thinking about adding that field, but it seems to be appropriate for
net-next. I'm resending this patch as is for now.

Thanks,
Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html