netdev - Re: [PATCH] ipv6: simplify code structure in addrconf.c/manage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2014 21:21:39 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Heiner Kallweit <heiner.kallweit@....de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: simplify code structure in addrconf.c/manage_tempaddrs

On Mon, Mar 31, 2014 at 08:47:42PM +0200, Heiner Kallweit wrote:
> read_unlock_bh can be moved out of the if clause
> 
> Signed-off-by: Heiner Kallweit <heiner.kallweit@....de>
> ---
>  net/ipv6/addrconf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 6c7fa08..a65812f 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2122,6 +2122,7 @@ static void manage_tempaddrs(struct inet6_dev *idev,
>  		if (!(flags&IFA_F_TENTATIVE))
>  			ipv6_ifa_notify(0, ift);
>  	}
> +	read_unlock_bh(&idev->lock);
>  
>  	if ((create || list_empty(&idev->tempaddr_list)) &&
>  	    idev->cnf.use_tempaddr > 0) {
> @@ -2130,10 +2131,7 @@ static void manage_tempaddrs(struct inet6_dev *idev,
>  		 * Also create a temporary address if it's enabled but
>  		 * no temporary address currently exists.
>  		 */
> -		read_unlock_bh(&idev->lock);
>  		ipv6_create_tempaddr(ifp, NULL);
> -	} else {
> -		read_unlock_bh(&idev->lock);

Doesn't the lock also protect the list_empty? I remember there is
a list_empty_careful to check concurrently if empty during possible
modification. I actually would leave it as is.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html