netdev - Re: [PATCH net] ipv6: some ipv6 statistic counters failed to disable bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140331.163904.1733729527022532179.davem@davemloft.net>
Date:	Mon, 31 Mar 2014 16:39:04 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	festevam@...il.com, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] ipv6: some ipv6 statistic counters failed to
 disable bh

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 31 Mar 2014 20:14:10 +0200

> After commit c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify
> processing to workqueue") some counters are now updated in process context
> and thus need to disable bh before doing so, otherwise deadlocks can
> happen on 32-bit archs. Fabio Estevam noticed this while while mounting
> a NFS volume on an ARM board.
> 
> As a compensation for missing this I looked after the other *_STATS_BH
> and found three other calls which need updating:
> 
> 1) icmp6_send: ip6_fragment -> icmpv6_send -> icmp6_send (error handling)
> 2) ip6_push_pending_frames: rawv6_sendmsg -> rawv6_push_pending_frames -> ...
>    (only in case of icmp protocol with raw sockets in error handling)
> 3) ping6_v6_sendmsg (error handling)
> 
> Fixes: c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify processing to workqueue")
> Reported-by: Fabio Estevam <festevam@...il.com>
> Tested-by: Fabio Estevam <fabio.estevam@...escale.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---
> 
> I would propose this patch for -stable, too.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html