netdev - Re: [PATCH] net/phy: Remove return value for a void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcaRci3Q871NOc_BLQf81dyWjwWxgE5HgT_V1GtJToG7YA@mail.gmail.com>
Date:	Tue, 1 Apr 2014 12:59:45 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Shruti Kanetkar <Shruti@...escale.com>
Cc:	Joe Perches <joe@...ches.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Emilian Medve <Emilian.Medve@...escale.com>
Subject: Re: [PATCH] net/phy: Remove return value for a void function

Hi Shruti,

2014-04-01 12:53 GMT-07:00 Shruti Kanetkar <Shruti@...escale.com>:
> Hello Joe,
>
> Thank you for sharing the script.
> I shall give it a try and credit you for the script.

Can you run this spatch throughout the drivers/net/phy/ files to begin
with and see what interesting results it produces?

Thanks!

>
>> -----Original Message-----
>> From: Joe Perches [mailto:joe@...ches.com]
>> Sent: Tuesday, April 01, 2014 1:04 PM
>> To: Kanetkar Shruti-B44454
>> Cc: f.fainelli@...il.com; netdev@...r.kernel.org; Medve Emilian-EMMEDVE1
>> Subject: Re: [PATCH] net/phy: Remove return value for a void function
>>
>> Here's a spatch script for this:
>>
>> $ cat void_return.cocci
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>>       if (...)
>> -             return S;
>> +             { S; return; }
>> ...
>> }
>>
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>>       if (...) {
>> ...
>> -             return S;
>> +             S;
>>       }
>> ...
>> }
>>
>> @@
>> identifier func;
>> expression S;
>> @@
>> void func(...) {
>> ...
>> -     return S;
>> +     S;
>> }
>>
>>
>>
>
> Regards,
> Shruti



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html