netdev - Re: [PATCH] net: ptp: move PTP classifier in its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 01 Apr 2014 16:43:37 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	dborkman@...hat.com
Cc:	richardcochran@...il.com, ast@...mgrid.com, fengguang.wu@...el.com,
	netdev@...r.kernel.org, jbenc@...hat.com
Subject: Re: [PATCH] net: ptp: move PTP classifier in its own file

From: Daniel Borkmann <dborkman@...hat.com>
Date: Tue,  1 Apr 2014 16:20:23 +0200

> This commit fixes a build error reported by Fengguang, that is
> triggered when CONFIG_NETWORK_PHY_TIMESTAMPING is not set:
> 
>   ERROR: "ptp_classify_raw" [drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.ko] undefined!
> 
> The fix is to introduce its own file for the PTP BPF classifier,
> so that PTP_1588_CLOCK and/or NETWORK_PHY_TIMESTAMPING can select
> it independently from each other. IXP4xx driver on ARM needs to
> select it as well since it does not seem to select PTP_1588_CLOCK
> or similar that would pull it in automatically.
> 
> This also allows for hiding all of the internals of the BPF PTP
> program inside that file, and only exporting relevant API bits
> to drivers.
> 
> This patch also adds a kdoc documentation of ptp_classify_raw()
> API to make it clear that it can return PTP_CLASS_* defines. Also,
> the BPF program has been translated into bpf_asm code, so that it
> can be more easily read and altered (extensively documented in [1]).
> 
> In the kernel tree under tools/net/ we have bpf_asm and bpf_dbg
> tools, so the commented program can simply be translated via
> `./bpf_asm -c prog` where prog is a file that contains the
> commented code. This makes it easily readable/verifiable and when
> there's a need to change something, jump offsets etc do not need
> to be replaced manually which can be very error prone. Instead,
> a newly translated version via bpf_asm can simply replace the old
> code. I have checked opcode diffs before/after and it's the very
> same filter.
> 
>   [1] Documentation/networking/filter.txt
> 
> Fixes: 164d8c666521 ("net: ptp: do not reimplement PTP/BPF classifier")
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>

Looks good, applied, thanks Daniel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html