netdev - Re: [PATCH 1/1] iproute2: wrong error when label is more than 15 chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140331204845.6496a28c@nehalam.linuxnetplumber.net>
Date:	Mon, 31 Mar 2014 20:48:45 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Swapnil Nagarkar <snagarka@...hat.com>
Cc:	netdev@...r.kernel.org, psabata@...hat.com
Subject: Re: [PATCH 1/1] iproute2: wrong error when label is more than 15
 chars

On Wed, 26 Mar 2014 16:09:48 +0530
Swapnil Nagarkar <snagarka@...hat.com> wrote:

> The string for "label" option in "ip" command does not take more than 15 chanracters.
> Gives error "RTNETLINK answers: Numerical result out of range".
> $ ip addr add 10.65.X.X/23 dev em1:1 label em1:123456789012
> RTNETLINK answers: Numerical result out of range
> $ ip addr add 10.65.X.X/23 dev em1:1 label em1:12345678901
> 
> Adding check for maximum length of interface name and proper error
> message.
> 
> After patch output:-
> $ ./ip addr replace 192.168.50.4 dev em1:123 label em1:123456789012
> Error: argument "em1:123456789012" is wrong: invalid label value.
> 
> Signed-off-by: Swapnil Nagarkar <snagarka@...hat.com>

I am not sure I like ip route commands trying to "fix up" kernel errors
like this. There are lots of possible error cases, and this one is so much
a corner case it doesn't seem right to step in and do something special.

The error number comes from the netlink attribute validation policy
and although the glibc error string is less than useful, the concept of
name too long does fit in the general meaning of ERANGE.

Unless there is a compelling outcry, I am going to reject this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html