| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1396388550-23081-17-git-send-email-mkl@pengutronix.de> Date: Tue, 1 Apr 2014 23:42:30 +0200 From: Marc Kleine-Budde <mkl@...gutronix.de> To: netdev@...r.kernel.org Cc: davem@...emloft.net, linux-can@...r.kernel.org, kernel@...gutronix.de, Thomas Gleixner <tglx@...utronix.de>, Marc Kleine-Budde <mkl@...gutronix.de> Subject: [PATCH 16/16] can: c_can: Avoid led toggling for every packet. From: Thomas Gleixner <tglx@...utronix.de> There is no point to toggle the RX led for every packet. Especially if we have a full FIFO we want to avoid everything we can. Signed-off-by: Thomas Gleixner <tglx@...utronix.de> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de> --- drivers/net/can/c_can/c_can.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 42c038d..01dc494 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -433,9 +433,6 @@ static int c_can_read_msg_object(struct net_device *dev, int iface, int ctrl) stats->rx_packets++; stats->rx_bytes += frame->can_dlc; - - can_led_event(dev, CAN_LED_EVENT_RX); - return 0; } @@ -901,6 +898,10 @@ static int c_can_do_rx_poll(struct net_device *dev, int quota) pkts += n; quota -= n; } + + if (pkts) + can_led_event(dev, CAN_LED_EVENT_RX); + return pkts; } -- 1.9.0.279.gdc9e3eb -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists