netdev - Re: [PATCH net-next] vxlan: fix handling of the inner 8021Q tagged frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bnwl1jwi.wl%atzm@stratosphere.co.jp>
Date:	Tue, 01 Apr 2014 18:25:17 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: fix handling of the inner 8021Q tagged frame


Hi Stephen,

At Mon, 31 Mar 2014 17:46:56 -0700,
Stephen Hemminger wrote:
> 
> On Mon, 31 Mar 2014 15:56:09 +0900
> Atzm Watanabe <atzm@...atosphere.co.jp> wrote:
> 
> > +	ether_addr_copy(key.eth_addr, eth_hdr(skb)->h_source);
> > +	if (ntohs(eth_hdr(skb)->h_proto) == ETH_P_8021Q)
> > +		key.vlan_id = ntohs(vlan_eth_hdr(skb)->h_vlan_TCI) & VLAN_VID_MASK;
> > +	else
> > +		key.vlan_id = 0;
> > +
> 
> What about QinQ vlan's?

This patch supports only single tagged frame currently.
But, indeed, key.vlan_id will be set to 0 even when
receiving the Q-in-Q double tagged frame...

So I'll send a patch v2 that will learn a topmost VID
when receiving ETH_P_8021AD frame.

If it must learn all nested VIDs, firstly we should design
the handling of Q-in-Q nested VIDs on the "bridge" command,
IMHO.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html