netdev - Re: [PATCH v3 net] xen-netback: disable rogue vif in kthread context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140401114428.GA6382@zion.uk.xensource.com>
Date:	Tue, 1 Apr 2014 12:44:28 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	Wei Liu <wei.liu2@...rix.com>, <netdev@...r.kernel.org>,
	<xen-devel@...ts.xen.org>, <zoltan.kiss@...rix.com>,
	<edwin@...rok.net>, Ian Campbell <ian.campbell@...rix.com>
Subject: Re: [PATCH v3 net] xen-netback: disable rogue vif in kthread context

On Tue, Apr 01, 2014 at 12:36:52PM +0100, David Vrabel wrote:
> On 01/04/14 12:33, Wei Liu wrote:
> > @@ -1574,6 +1575,16 @@ int xenvif_kthread(void *data)
> >  		wait_event_interruptible(vif->wq,
> >  					 rx_work_todo(vif) ||
> >  					 kthread_should_stop());
> 
> I think you're still missing a || vif->disabled from this wait_event
> conditional.
> 

Good catch. I will resubmit.

Wei.

> David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html