lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Apr 2014 16:38:44 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Byungho An <bh74.an@...sung.com> Cc: Girish K S <ks.giri@...sung.com>, Siva Reddy Kallam <siva.kallam@...sung.com>, Vipul Pandya <vipul.pandya@...sung.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: [patch 1/3] net: sxgbe: sxgbe_mdio_register() frees the bus "err" is always zero at this point so we always unregister and free the mdio_bus before returning success. This seems like left over code and I have deleted it. Fixes: 1edb9ca69e8a ('net: sxgbe: add basic framework for Samsung 10Gb ethernet driver') Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> --- Static analysis. Untested. diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c index b0eb0a2..01af2cb 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c @@ -219,13 +219,6 @@ int sxgbe_mdio_register(struct net_device *ndev) } } - if (!err) { - netdev_err(ndev, "PHY not found\n"); - mdiobus_unregister(mdio_bus); - mdiobus_free(mdio_bus); - goto mdiobus_err; - } - priv->mii = mdio_bus; return 0; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists